Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgraded versions.tf to include minor bumps from tpg v5 #125

Merged
merged 2 commits into from
Oct 20, 2023
Merged

chore: upgraded versions.tf to include minor bumps from tpg v5 #125

merged 2 commits into from
Oct 20, 2023

Conversation

g-awmalik
Copy link
Contributor

@g-awmalik g-awmalik commented Oct 6, 2023 •
edited by apeabody
Loading

This also remove the data block from the vpn_ha module used to lookup if a router already existed. With TGP v5, that block returns a 404 if the router doesn't exist causing the plan to fail. Based on this change, if a user wants to use an existing router, they should import it before running the plan.

BEGIN_COMMIT_OVERRIDE
fix: upgraded versions.tf to include minor bumps from tpg v5 (#125)
END_COMMIT_OVERRIDE

@g-awmalik g-awmalik requested review from imrannayer and a team as code owners October 6, 2023 23:39
@g-awmalik
Copy link
Contributor Author

@imrannayer - can you take a look at this?

@imrannayer
Copy link
Collaborator

@g-awmalik my understanding of the module was that if you provide "" for router_name module will create a router otherwise it will assume the router already exists in GCP environment created outside of this module.
Ideally it should be separate variable create_router which should dictate this logic irrespective of router_name.

@g-awmalik
Copy link
Contributor Author

@g-awmalik my understanding of the module was that if you provide "" for router_name module will create a router otherwise it will assume the router already exists in GCP environment created outside of this module. Ideally it should be separate variable create_router which should dictate this logic irrespective of router_name.

That is right. Thanks for jogging my memory on that. Modified the logic to account for that.

@imrannayer
Copy link
Collaborator

@g-awmalik I dont see integration test in checks. Can you plz check?

@imrannayer imrannayer merged commit 72bb554 into master Oct 20, 2023
7 checks passed
@imrannayer imrannayer deleted the chore/tpg-bump branch October 20, 2023 19:39
@apeabody
Copy link
Contributor

@imrannayer - A quick follow-up so the example/CI can also run with TPG 5: #128

@apeabody apeabody added the release-please:force-run Force release-please to check for changes. label Oct 20, 2023
@release-please release-please bot removed the release-please:force-run Force release-please to check for changes. label Oct 20, 2023
@release-please release-please bot mentioned this pull request Oct 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imrannayer imrannayer imrannayer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@g-awmalik @imrannayer @apeabody